fix: bypass ai for singleton-backed viewmodels#13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes AI bypass detection more conservative for ViewModels that depend on direct singleton collaborators.
Included changes
kotlinx-coroutines-testWhy this change
d2t auto --ainarrows analysis to changed methods.That meant singleton-backed ViewModels could still slip into the AI path when the changed method did not directly contain the singleton access, even though the file as a whole was still not a safe AI target.
This PR fixes that mismatch by treating the full ViewModel source as the bypass boundary.
Expected outcome
After this PR is merged:
auto --aiis less likely to send large unnecessary model requests for unsafe targetsValidation
./gradlew --no-daemon :modules:test-generator:test --tests dev.diff2test.android.testgenerator.OpenAiResponsesTestGeneratorTestNotes